Optimize zlabel usage for stringlabels #8077
Open
+742
−467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the ZLabelsToPromLabels hack is no longer free with stringlabels because the in-memory format of the two types is different. Because of this, using a stringlabels build in the Receiver can be more CPU intensive than the normal build. In order to allow for an efficient usage of stringlabels, this commit removes `ZLabelsToPromLabels` calls in TSDBStore and ProxyStore. There is now a specialized implementation of ZLabel conversion functions with a stringlabels build tag in order to avoid panics, but long term we should get rid of these functions if possible. Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
zlabels-stringlabels
branch
from
8d0f284 to
f69bf44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ZLabelsToPromLabels hack is no longer free with stringlabels because the in-memory format of the two types is different. Because of this, using a stringlabels build in the Receiver can be more CPU intensive than the normal build.
In order to allow for an efficient usage of stringlabels, this commit removes
ZLabelsToPromLabelscalls in TSDBStore and ProxyStore. There is now a specialized implementation of ZLabel conversion functions with a stringlabels build tag in order to avoid panics, but long term we should get rid of these functions if possible.Changes
Verification