Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show my trail? #77

Open
filbo opened this issue Apr 16, 2022 · 2 comments
Open

show my trail? #77

filbo opened this issue Apr 16, 2022 · 2 comments

Comments

@filbo
Copy link

filbo commented Apr 16, 2022

The summary at the end of a game shows the flags of the guessed countries, sorted by closeness to the answer. I'd like to see my discovery path.

The 'you won' state also shows the globe, with the clicked countries colored in, but again no indication of guessing order.

Suggestions:

  • starting with the first guessed country, draw a path from one guess to the next; probably from each country's center-of-mass or something like that. (Not closest points, or at least, not for country-pairs which actually touch each other; I suppose in that case a line through the border, extending partway into each country, could work.) Either way there are some mildly tricky issues about concave countries and stuff like that -- the center-of-mass of Vietnam looks like it's somewhere in Laos, for instance... needs a 'reasonable pivot point' algorithm something like: center of mass in the longest direction, crossed by center of physical breadth on the perpendicular axis through that center of mass... by this algorithm (by eyeball and best guess), the 'center' of Vietnam is approximately Hang Cha Loi

  • allow the end-game summary to be sorted by closeness or by guess order (live toggle on the page)

  • slightly orthogonal, but, during play the cursor will identify already-guessed countries by name, but not untouched countries. This is sensible. After the game has ended, could you (1) draw in boundaries of all countries and (2) make all countries self-ID on hover? Or just (2) + 'glow' countries as you hover them (so you can ephemerally see the borders of individual countries which weren't on the guess list)

@filbo
Copy link
Author

filbo commented Apr 18, 2022

Mock-up of the 1st 2 points (not going to attempt the add-boundaries suggestion with a paint program!)
globle

@the-abe-train
Copy link
Owner

This is actually a really cool idea, and definitely possible, but not something I have the capacity to tackle right now. Let's leave this issue open in case anyone wants to take a crack at it with a PR. Otherwise, I'll consider implementing it in the future. Thanks for taking an interest in improving the game!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants