Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the order number of each guess in the guessed countries list #86

Merged
merged 3 commits into from
May 30, 2022

Conversation

JNPLZ
Copy link
Contributor

@JNPLZ JNPLZ commented Apr 27, 2022

Hey there,

I've seen PR #77 and implemented the suggestion.
You can now see the guesses' order number behind the country name.

Hope you like it, I'm looking forward to your feedback.
Jennifer

#77

Bildschirmfoto 2022-04-27 um 15 05 44

@the-abe-train
Copy link
Owner

I'm a little bit worried people might be confused what these numbers mean. Any ideas how we can make it clear?

@JNPLZ
Copy link
Contributor Author

JNPLZ commented Apr 28, 2022

I've played around a bit and implemented a toogle button at the bottom to switch between the sorting by distance/guesses.

Bildschirmfoto 2022-04-28 um 11 44 51

Bildschirmfoto 2022-04-28 um 11 44 52

Bildschirmfoto 2022-04-28 um 11 49 12

I added the code for that to the PR.

Other things I tried but didn't like that much:

Bildschirmfoto 2022-04-28 um 09 27 26

Bildschirmfoto 2022-04-28 um 09 29 10

Bildschirmfoto 2022-04-28 um 09 48 50

What do you think?

EDIT: Another possibility could be a combination: show/hide the second, lower list of guess order (as seen in the last screenshot) by clicking on the button.

@filbo
Copy link

filbo commented May 25, 2022

Maybe show the 'closest border' metric on each guess? Plus the toggle between guess-order and closest-order. So the 'guess order' might look like (distances made up [badly] by eye):

Guess order:

1: Eritrea 2500km  2: Chad 2000km     3: Morocco 3000km  4: Cyprus 4000km
5: S.Af. 753km     6: Mad. 1700km     7: ANGOLA 0km!

vs.

Distance order:

7: ANGOLA 0km!     5: S.Af. 753km     6: Mad. 1700km     2: Chad 2000km
1: Eritrea 2500km  3: Morocco 3000km  4: Cyprus 4000km

... and the toggle control can be the words 'Guess order' / 'Distance order', highlighted somehow to indicate that it's a control.

@filbo filbo mentioned this pull request May 25, 2022
@the-abe-train
Copy link
Owner

I love these updates! I'm going to merge it into a test branch so I can play around with it a bit and maybe make some style changes, but I really appreciate the work you guys have done here!

@the-abe-train the-abe-train changed the base branch from master to pride May 30, 2022 19:07
@the-abe-train the-abe-train merged commit 0a22e71 into the-abe-train:pride May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants