Added ability to set error message per pattern. Closes #174

README.md

@@ -739,12 +739,18 @@ The validator should return an error message when the value is invalid, and noth
 
 If you have custom patterns that are used several places in your code, you can extend the patterns with your own. And if you don't like the default implementation of one of the built-ins, you can override it.
 
+Remember to also provide a default error message for it.
+
 ```js
 _.extend(Backbone.Validation.patterns, {
   myPattern: /my-pattern/,
   email: /my-much-better-email-regex/
 });
 
+_.extend(Backbone.Validation.messages, {
+  myPattern: 'This is an error message'
+});
+
 var Model = Backbone.Model.extend({
   validation: {
     name: {
@@ -874,6 +880,7 @@ Basic behaviour:
 #### Master
 
 * Fixed undefined format function when calling one of the built in validators form within a method validator. Fixes #98
+* BREAKING: Added ability to set error message per pattern. This means that if you have custom patterns, or have change the default one, you need to [add/change a default message](http://thedersen.com/projects/backbone-validation/#extending-backbone-validation/adding-custom-patterns) for it.
 
 #### v0.8.2 [commits](https://github.com/thedersen/backbone.validation/compare/v0.8.1...v0.8.2)
 

dist/backbone-validation-amd.js

@@ -430,7 +430,11 @@
       rangeLength: '{0} must be between {1} and {2} characters',
       oneOf: '{0} must be one of: {1}',
       equalTo: '{0} must be the same as {1}',
-      pattern: '{0} must be a valid {1}'
+      digits: '{0} must only contain digits',
+      number: '{0} must be a number',
+      email: '{0} must be a valid email',
+      url: '{0} must be a valid url',
+      inlinePattern: '{0} is invalid'
     };
 
     // Label formatters
@@ -621,7 +625,7 @@
         // Can be a regular expression or the name of one of the built in patterns
         pattern: function(value, attr, pattern, model) {
           if (!hasValue(value) || !value.toString().match(defaultPatterns[pattern] || pattern)) {
-            return this.format(defaultMessages.pattern, this.formatLabel(attr, model), pattern);
+            return this.format(defaultMessages[pattern] || defaultMessages.inlinePattern, this.formatLabel(attr, model), pattern);
           }
         }
       };

dist/backbone-validation.js

@@ -423,7 +423,11 @@ Backbone.Validation = (function(_){
     rangeLength: '{0} must be between {1} and {2} characters',
     oneOf: '{0} must be one of: {1}',
     equalTo: '{0} must be the same as {1}',
-    pattern: '{0} must be a valid {1}'
+    digits: '{0} must only contain digits',
+    number: '{0} must be a number',
+    email: '{0} must be a valid email',
+    url: '{0} must be a valid url',
+    inlinePattern: '{0} is invalid'
   };
 
   // Label formatters
@@ -614,7 +618,7 @@ Backbone.Validation = (function(_){
       // Can be a regular expression or the name of one of the built in patterns
       pattern: function(value, attr, pattern, model) {
         if (!hasValue(value) || !value.toString().match(defaultPatterns[pattern] || pattern)) {
-          return this.format(defaultMessages.pattern, this.formatLabel(attr, model), pattern);
+          return this.format(defaultMessages[pattern] || defaultMessages.inlinePattern, this.formatLabel(attr, model), pattern);
         }
       }
     };

src/backbone-validation.js

@@ -416,7 +416,11 @@ Backbone.Validation = (function(_){
     rangeLength: '{0} must be between {1} and {2} characters',
     oneOf: '{0} must be one of: {1}',
     equalTo: '{0} must be the same as {1}',
-    pattern: '{0} must be a valid {1}'
+    digits: '{0} must only contain digits',
+    number: '{0} must be a number',
+    email: '{0} must be a valid email',
+    url: '{0} must be a valid url',
+    inlinePattern: '{0} is invalid'
   };
 
   // Label formatters
@@ -607,7 +611,7 @@ Backbone.Validation = (function(_){
       // Can be a regular expression or the name of one of the built in patterns
       pattern: function(value, attr, pattern, model) {
         if (!hasValue(value) || !value.toString().match(defaultPatterns[pattern] || pattern)) {
-          return this.format(defaultMessages.pattern, this.formatLabel(attr, model), pattern);
+          return this.format(defaultMessages[pattern] || defaultMessages.inlinePattern, this.formatLabel(attr, model), pattern);
         }
       }
     };

tests/validators/pattern.js

@@ -34,6 +34,14 @@ buster.testCase("pattern validator", {
         this.model.set({email:''}, {validate: true});
     },
 
+    "has default error message for inline pattern": function(done) {
+        this.model.bind('validated:invalid', function(model, error){
+            assert.equals({name: 'Name is invalid'}, error);
+            done();
+        });
+        this.model.set({name:''}, {validate: true});
+    },
+
     "value not matching pattern is invalid": function() {
         refute(this.model.set({
             name: 'aaa'