Fixes #21641 - Drop jquery-ui spinners in favor of React implementation

[yifatmakias]

No description provided.

[theforeman-bot]

Issues: #21641

[ezr-ondrej]

The failures are definitelly not relevant, probably some npm package update?
I'll investigate next week if noone would get to it sooner.

[MariaAga]

This shouldn't be merged before it's usage is removed in plugins:
https://github.com/search?q=org%3Atheforeman+numFields&type=code
Also the deprecation says that it will be only removed in foreman 3.0

[ezr-ondrej]

This shouldn'd be merged before it's usage is removed in plugins:
https://github.com/search?q=org%3Atheforeman+numFields&type=code
Also the deprecation says that it will be only removed in foreman 3.0

there is multiple levels to answer this.

1. 2.6 = 3.0 I'm just working on writup for it
2. plugins had time to do that, we should not be as concerned with plugins using some deprecated stuff
3. to ease the point 2, because we gave just one version to plugins to deal with this, the function calls can probably be just removed, as we have changed the helpers implementation to react implementation, so the initializers in the plugin just dosn't do anything

This being sad, we could leave blank function with the deprecation warning only for one more version, so the plugins don't get js errors just by calling useless function.
EDIT: Though I would just prefer plugin maintainers to remove the calls and also by that verify the new implementation is working for them. It is simple removal and simple test, that IMHO is not too much to ask from plugin maintainers if they wish to keep the plugins alive.

[ekohl]

If it's a simple migration, it can be beneficial (and faster) to submit a PR yourself.

[ezr-ondrej]

I can imagine having in this file

const numFieldsDeprecationOnly = {
  initAll: () => { window.tfm.tools.deprecate('initAll()', 'does nothing as of now, please stop calling it',    '3.2') };
};

And then here: numFields: numFieldsDeprecationOnly, Which would prevent plugins from failing hard on the function missing for two more version.

[ezr-ondrej]

Nice work!
Just noticed we are leaving some bits behind, can we drop these requires? :)

• foreman/app/assets/javascripts/application.js

  Line 1 in dcf1135

  //= require jquery-ui/widgets/spinner

• foreman/app/assets/stylesheets/application.scss

  Lines 5 to 6 in dcf1135

  	@import 'jquery-ui/spinner';
  	@import 'jquery.ui.spinner_custom';

• [whole file] https://github.com/theforeman/foreman/blob/dcf11351d798bc59886fded3e0dfbff01ea98482/app/assets/stylesheets/jquery.ui.spinner_custom.scss

[ezr-ondrej]

Thanks @yifatmakias ! Great drop 👍