Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore IIIF choice annotations on in-page figures #995

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

cbutcosk
Copy link
Collaborator

@cbutcosk cbutcosk commented Feb 5, 2025

This PR restores interactive behaviors for in-page figures that use annotations / IIIF choices.

  • Adjusts the uri for base image annotations to use print image JPEGs instead of info.json to eliminate oddities in canvas-panel behavior and better align with IIIF community practices
  • Enables interactivity for in-page figures that have annotations

Resolves DEV-19082

Copy link
Member

@mphstudios mphstudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbutcosk nice work debugging the IIIF manifest, with the addition of a README to document that this pull request looks ready to merge.

@mphstudios mphstudios self-requested a review February 10, 2025 19:52
@cbutcosk cbutcosk merged commit 7a5ce71 into main Feb 11, 2025
@cbutcosk cbutcosk deleted the feature/figure-in-page-iiif-choices branch February 11, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants