Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Fix structured metadata script tag #21

Closed
aidanatwork opened this issue Feb 10, 2021 · 2 comments
Closed

Fix structured metadata script tag #21

aidanatwork opened this issue Feb 10, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@aidanatwork
Copy link
Contributor

script tag for structured data is rendering to the page and probably not crawlable. need to wrap it in curly braces and add instructions to the user telling them to add this tag to their page HTML.

@aidanatwork aidanatwork self-assigned this Feb 10, 2021
@aidanatwork aidanatwork added the bug Something isn't working label Feb 10, 2021
aidanatwork added a commit that referenced this issue Feb 17, 2021
Adds explanation of what to do with the structured metadata script tag, and formats it as a code example rather than plain text on the page. Addresses issue 21: #21
@aidanatwork aidanatwork mentioned this issue Feb 17, 2021
6 tasks
@camerons
Copy link
Member

Aidan, I was looking at Choco's logging template, and the front matter that I believe we are going to have in our future markdown, and I wonder whether this front mater could be auto-converted into JSON-LD during the publishing process?
This might get around the poor rendering of metadata in github, and still keep the metadata in the final doc.

aidanatwork added a commit that referenced this issue Feb 23, 2021
@aidanatwork
Copy link
Contributor Author

Just merged my fix for this issue into Cameron's branch, so I'm going to close this issue out.

camerons pushed a commit to camerons/incubator that referenced this issue Feb 27, 2021
Adds explanation of what to do with the structured metadata script tag, and formats it as a code example rather than plain text on the page. Addresses issue 21: thegooddocsproject/incubator#21
camerons pushed a commit to camerons/templates that referenced this issue Feb 28, 2021
Adds explanation of what to do with the structured metadata script tag, and formats it as a code example rather than plain text on the page. Addresses issue 21: thegooddocsproject/incubator#21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants