-
Notifications
You must be signed in to change notification settings - Fork 171
Conversation
@jaredmorgs @shreyas1599 review, please. |
api-overview/about-overview.md
Outdated
https://developer.chrome.com/native-client/overview | ||
|
||
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform | ||
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma should not be removed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you could probably replace the stale link. You must've missed this when you opened a PR for stale links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will undo it and replace the link as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks @shreyas1599
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking good from what I can see here. Thanks for the work done here @Dishebh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dishebh Let me know what you think of this.
api-overview/about-overview.md
Outdated
|
||
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform | ||
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. [A brief overview of Jira](https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about changing the first sentence to This overview of The Jira Platform
... And then using that as the link text instead of adding a separate separate sentence in the end. You could do this for the Chrome Native Client as well
. What is your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me as well. Thanks for the suggestion; I'll make the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyas1599 I did the required changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't have merge permission. @jaredmorgs will do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty good to me. Nice collaboration here folks.
@jaredmorgs it would be great if it could be merged :) |
Thank you for your contributions and your patience! :) |
Resolves #132
Corrected a sentence, grammatically; and added grammatical operators wherever necessary (relevant).