Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Made some grammatical corrections #137

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

Dishebh
Copy link
Contributor

@Dishebh Dishebh commented May 22, 2020

Resolves #132

Corrected a sentence, grammatically; and added grammatical operators wherever necessary (relevant).

@Dishebh
Copy link
Contributor Author

Dishebh commented May 22, 2020

@jaredmorgs @shreyas1599 review, please.

https://developer.chrome.com/native-client/overview

* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma should not be removed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you could probably replace the stale link. You must've missed this when you opened a PR for stale links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will undo it and replace the link as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks @shreyas1599

@Dishebh Dishebh force-pushed the unclear-sentence branch from f458304 to c76511d Compare May 23, 2020 06:58
Copy link
Contributor

@jaredmorgs jaredmorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking good from what I can see here. Thanks for the work done here @Dishebh

Copy link
Contributor

@shreyas1599 shreyas1599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dishebh Let me know what you think of this.


* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform
* **The Jira Platform**. This overview does a good job of explaining multiple products and the associated use cases, uses, third-party integrations, hosting options, and licensing. [A brief overview of Jira](https://www.atlassian.com/software/jira/guides/getting-started/overview#about-the-jira-platform)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about changing the first sentence to This overview of The Jira Platform... And then using that as the link text instead of adding a separate separate sentence in the end. You could do this for the Chrome Native Client as well. What is your opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me as well. Thanks for the suggestion; I'll make the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyas1599 I did the required changes.

Copy link
Contributor

@shreyas1599 shreyas1599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't have merge permission. @jaredmorgs will do it.

Copy link
Contributor

@jaredmorgs jaredmorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good to me. Nice collaboration here folks.

@Dishebh
Copy link
Contributor Author

Dishebh commented Jun 26, 2020

@jaredmorgs it would be great if it could be merged :)

@emckean
Copy link
Contributor

emckean commented Jul 15, 2020

Thank you for your contributions and your patience! :)

@emckean emckean merged commit e21158d into thegooddocsproject:master Jul 15, 2020
@Dishebh Dishebh deleted the unclear-sentence branch July 15, 2020 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear sentence: This overview explains and engine ...
5 participants