Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

readme edits to C/T/R #144

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Conversation

Loquacity
Copy link
Member

Addresses: #73
Additionally, frames the C/T/R discussion in terms of the information seeking behaviour (learning/doing/fact-checking).
Also, removed some of the word/phrases that my current linters didn't like.

Question for maintainers: I noticed the use of en_GB spelling in this doc, and couldn't find guidance on dialect. Is there a preference?

Copy link
Contributor

@jaredmorgs jaredmorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent revisions, Lana. I like the parallelism in the revised sections.

I believe we have shifted to en_US in line with the Google Developer Style Guide.

@Loquacity
Copy link
Member Author

Excellent revisions, Lana. I like the parallelism in the revised sections.

Thanks.

I believe we have shifted to en_US in line with the Google Developer Style Guide.

Updated :)

@Loquacity
Copy link
Member Author

Thanks for the review, Jared. Are you able to add more reviewers to the list? I don't have perms.

@Loquacity
Copy link
Member Author

Resolved conflicts.

@Loquacity
Copy link
Member Author

Thanks for the review, Jared. Are you able to add more reviewers to the list? I don't have perms.

I have perms now, so have added the suggested reviewers.

@aidanatwork aidanatwork merged commit 0becb69 into thegooddocsproject:master Oct 7, 2020
@aidanatwork
Copy link
Contributor

Given the approval from Jared and thumbs up from me and Loquacity, I'm merging this PR.

@Loquacity Loquacity deleted the readme-edit branch October 8, 2020 00:13
@acpkendo acpkendo mentioned this pull request Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants