Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeleniumTunnel: Can't start Selenium 3.0.0+ #35

Closed
bdpartridge opened this issue Oct 19, 2016 · 2 comments
Closed

SeleniumTunnel: Can't start Selenium 3.0.0+ #35

bdpartridge opened this issue Oct 19, 2016 · 2 comments

Comments

@bdpartridge
Copy link

bdpartridge commented Oct 19, 2016 •
edited
Loading

Description
Can't start Selenium version 3.0.0+ with SeleniumTunnel. The root cause appears to be related to the new requirement that "-D" parameters be passed to the java CLI before the "-jar" parameter. See SeleniumHQ/selenium#2566 for additional details.

Steps to Reproduce
digdug: 1.5.0
Node: 4.1.1
OS: Mac OS X El Capitan (10.11.6)

  • When starting the Intern test runner, pass in a config that specifies a Selenium version that's >=3.0.0.
  • Selenium is not started and an exception is thrown (see below).

Expected Result
DigDug starts Selenium 3.0.0+.

Actual Result
Selenium fails to start. Here's a sample stack trace:

`Listening on 0.0.0.0:9000
Error: Tunnel failed to start: Exception in thread "main" com.beust.jcommander.ParameterException: Unknown option: -Dwebdriver.chrome.driver=/Users/bpartridge/forward/fwd/web/src/main/resources/web/node_modules/intern/node_modules/digdug/selenium-standalone/chromedriver
at com.beust.jcommander.JCommander.parseValues(JCommander.java:742)
at com.beust.jcommander.JCommander.parse(JCommander.java:282)
at com.beust.jcommander.JCommander.parse(JCommander.java:265)
at com.beust.jcommander.JCommander.(JCommander.java:210)
at org.openqa.grid.selenium.GridLauncherV3$1.setConfiguration(GridLauncherV3.java:219)
at org.openqa.grid.selenium.GridLauncherV3.buildLauncher(GridLauncherV3.java:147)
at org.openqa.grid.selenium.GridLauncherV3.main(GridLauncherV3.java:73)

at handleChildExit <node_modules/intern/node_modules/digdug/Tunnel.js:336:16>
at ChildProcess. <node_modules/intern/node_modules/digdug/Tunnel.js:371:6>
at emitTwo events.js:92:20
at ChildProcess.emit events.js:172:7
at Process.ChildProcess._handle.onexit <internal/child_process.js:200:12>`

I'd be happy to submit a PR for this if that would help.
@jason0x43
Copy link
Member

This should be a pretty straightforward fix. Selenium 3 is pickier about command line argument ordering. All -D options need to come before the -jar option. (See SeleniumHQ/selenium#2566.)

@bdpartridge
Copy link
Author

Great! Thanks for fixing this.

jason0x43 added a commit that referenced this issue Mar 21, 2017
@jason0x43
Move -D args before -jar for SeleniumTunnel
2ab3012 
-D args are supposed to come before -jar, and at least Selenium 3
requires this.

fixes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdpartridge @jason0x43