Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that whenever we add information to obs or var that the user is informed #246

Closed
Zethson opened this issue Jan 12, 2022 · 0 comments · Fixed by #426
Closed

Ensure that whenever we add information to obs or var that the user is informed #246

Zethson opened this issue Jan 12, 2022 · 0 comments · Fixed by #426
Assignees
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Jan 12, 2022

Whenever the AnnData object is modified the user should get informed. Scanpy, cellrank and others use the logger to inform the user in such cases. We should also create our own logger instance and add logging info whenever the AnnData gets modified with a corresponding message.

Investigate cellrank for an example of how to create & structure such a logger. Cellrank:

        logg.info(
            f"Adding `adata.obs[{key!r}]`\n       `adata.obs[{Key.uns.colors(key)!r}]`\n",
            time=time,
        )

https://github.com/theislab/cellrank/blob/master/cellrank/logging/_logging.py

@Zethson Zethson added the enhancement New feature or request label Jan 12, 2022
@Zethson Zethson self-assigned this Jan 12, 2022
@Zethson Zethson added this to the 0.3 milestone Jan 12, 2022
@Zethson Zethson assigned namsaraeva and unassigned Zethson Aug 15, 2022
@namsaraeva namsaraeva linked a pull request Dec 1, 2022 that will close this issue
namsaraeva added a commit that referenced this issue Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants