[FEATURE] Display QC metrics of var #239 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- display qc metrics of var - obs might be too big to actually display
|
"are the QC metrics of var (the metric names) fixed or can they vary throughout different datasets? Cause currently the implementation just take every column in var and displays them, but that's not the desired behaviour!" Fixed so far, but maybe add a parameter to add additional columns for the display because people can add custom ones? |
Way to go for now, y |
- display qc metrics of var with extra columns if wanted - updated docs
Zethson
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
display qc metrics of var with extra columns if wanted
updated docs
@Zethson : are the QC metrics of var (the metric names) fixed or can they vary throughout different datasets? Cause currently the implementation just take every column in var and displays them, but that's not the desired behaviour!