-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SoftImpute and IterativeSVD to imputation #353
Conversation
Docstring needs to be updated. |
update docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on a first glance. Can this also be sped up with the Intel sklearn extension?
Think that @Imipenem should review this one.
@xinyuejohn you also need to add this function to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor stuff.
Please add the imputation methods to the docs (usage.rst) |
Signed-off-by: zethson <[email protected]>
@Zethson It seems this has no more issues. |
PR Checklist
docs
is updatedDescription of changes
Technical details
test_impute_iris.csv only contains numerical data and test_impute_titanic.csv contains numerical data and non-numerical data.