Missing values visualization, ref issue #271 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zethson
requested changes
Nov 14, 2022
There was a problem hiding this comment.
Thank you very much!
This is a high quality PR, well done!
- Please not defaults as
(default: xyz)in the docstrings. Just for consistency. Your style is technically also fine. - Generally I avoid parameter names such as "n" or "p". They might be described in the docstring, but they are not self explanatory. Instead of "p" you could consider "max_percentage" or something. Consider renaming them, please.
- Your PR has conflicts with the poetry lockfile. The easiest way for you to fix this is to merge development in your branch, deleting the lockfile and then regenerating it with
poetry lock
Thanks!
|
BTW, there are also 1-2 pre-commit issues that I'd kindly ask you to fix. |
Signed-off-by: zethson <[email protected]>
Zethson
reviewed
Nov 21, 2022
Signed-off-by: zethson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added four (matrix, barplot, heatmap, dendrogram) plotting functions from https://github.com/ResidentMario/missingno, updated imports and docs.
Technical details
For now I added all the arguments they use in their functions, but we can discuss what we really need and what can be removed for now.
Additional context
I am not sure how to give credits in a proper way. I just added a comment on th etop of the file, but I don't think it is the correct way to reference other repos.