Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tiny examples to every function #498

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Added tiny examples to every function #498

merged 3 commits into from
Apr 13, 2023

Conversation

namsaraeva
Copy link
Collaborator

@namsaraeva namsaraeva commented Apr 11, 2023

Added examples to some functions

@namsaraeva namsaraeva self-assigned this Apr 12, 2023
@namsaraeva namsaraeva linked an issue Apr 12, 2023 that may be closed by this pull request
@namsaraeva namsaraeva requested a review from Zethson April 12, 2023 15:48
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Great and you also fixed a few old docstrings

@@ -59,7 +59,7 @@ def write(
else:
# dummy encoding when there is non numerical data in X
if not np.issubdtype(adata.X.dtype, np.number) and extension == "h5ad":
# flag to indicate an Anndata object has been dummy encoded to write it to .h5ad file
# flag to indicate an anndata object has been dummy encoded to write it to .h5ad file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, was not really intended. We can rollback

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes pls

then merge it :)

@namsaraeva namsaraeva merged commit df886f8 into development Apr 13, 2023
@namsaraeva namsaraeva deleted the tinyexamples branch April 13, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that every function has a tiny example
2 participants