Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/knni amendments #706

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Enhancement/knni amendments #706

merged 4 commits into from
Apr 25, 2024

Conversation

eroell
Copy link
Collaborator

@eroell eroell commented Apr 25, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked n/a
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Two suggested changes:

  • check for valid backend: it can happen quickly to mispell an argument as long as 'scikit-learn', and then the default being used would be hidden (not speaking of own mishap, checking for a friend)
  • omit the **kwargs collector: I know... I just am not a fan of grabbing everything that might be a misspelt argument and throw it further down :)

Technical details

Additional context

@eroell eroell requested a review from Zethson April 25, 2024 20:37
Zethson
Zethson approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! <3

@Zethson Zethson marked this pull request as ready for review April 25, 2024 20:38
@Zethson Zethson merged commit 84d8c11 into theislab:main Apr 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eroell @Zethson