tests for spatial problems

[giovp]

@MUCDK so far encounter this mypy error due to multiple conftests.py. How do we go about it?

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

tests/problems/space/conftest.py: error: Duplicate module named "conftest" (also at "tests/conftest.py")
Found 1 error in 1 file (errors prevented further checking)

also I added the data generation step for (more complex) scenarios, however while doing it I realized that this would be needed for the regression tests but must say that in alignment case only case to do it against Paste for only the affine transform . Do you think it still makes sense?

[codecov]

Codecov Report

Merging #188 (fce788b) into master (dbf0ddf) will increase coverage by 5.85%.
The diff coverage is 77.21%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   71.07%   76.93%   +5.85%     
==========================================
  Files          24       24              
  Lines        1943     1981      +38     
  Branches      342      351       +9     
==========================================
+ Hits         1381     1524     +143     
+ Misses        463      350     -113     
- Partials       99      107       +8     

Impacted Files	Coverage Δ
moscot/solvers/_output.py	71.81% <66.66%> (-5.96%)	⬇️
moscot/analysis_mixins/_spatial_analysis.py	80.90% <72.50%> (+57.67%)	⬆️
moscot/analysis_mixins/_base_analysis.py	100.00% <100.00%> (+20.00%)	⬆️
moscot/backends/ott/_output.py	94.52% <100.00%> (+1.46%)	⬆️
moscot/problems/space/_alignment.py	86.36% <100.00%> (+26.36%)	⬆️
moscot/problems/space/_mapping.py	94.11% <100.00%> (+41.05%)	⬆️
moscot/problems/_base_problem.py	84.65% <0.00%> (+1.70%)	⬆️
moscot/solvers/_base_solver.py	89.56% <0.00%> (+1.73%)	⬆️
... and 6 more

[MUCDK]

@MUCDK so far encounter this mypy error due to multiple conftests.py. How do we go about it?

mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

tests/problems/space/conftest.py: error: Duplicate module named "conftest" (also at "tests/conftest.py")
Found 1 error in 1 file (errors prevented further checking)

also I added the data generation step for (more complex) scenarios, however while doing it I realized that this would be needed for the regression tests but must say that in alignment case only case to do it against Paste for only the affine transform . Do you think it still makes sense?

• Concerning the mypy errors I haven't found an easy workaround yet, maybe @michalk8 knows a solution. Still, I would like to keep the conftest file structure as it is because it's much cleaner this way.
• Concerning the regression test I am not entirely sure what you mean. Are you saying that for the alignment task test you need the generated data and you want to test the moscot implementation obviously only for the affine transformation and so you are not sure whether this is reason enough to include the code for the data generation here? If so, I would still include it.

[michalk8]

Concerning the mypy errors I haven't found an easy workaround yet, maybe @michalk8 knows a solution. Still, I would like to keep the conftest file structure as it is because it's much cleaner this way.

Please take a look at: https://docs.pytest.org/en/7.1.x/reference/fixtures.html#conftest-py-sharing-fixtures-across-multiple-files

[MUCDK]

Concerning the mypy errors I haven't found an easy workaround yet, maybe @michalk8 knows a solution. Still, I would like to keep the conftest file structure as it is because it's much cleaner this way.

Please take a look at: https://docs.pytest.org/en/7.1.x/reference/fixtures.html#conftest-py-sharing-fixtures-across-multiple-files

If I understand correctly there is no alternative to naming them 'conftest.py'

[giovp]

reading here: python/mypy#4008
it doesn't seem a clear solution exist. I think having mypy running is more important than nested fixtures so I wouldn't mind just putting everything in root conftest.py

[michalk8]

@giovp @MUCDK think my latest commit should work.

[giovp]

@MUCDK tests fails because of this

tests/problems/test_general_problem.py:1: in <module>
      from _utils import ATOL, RTOL, Geom_t, TestSolverOutput
  E   ModuleNotFoundError: No module named '_utils'

any idea? the file is exactly the same as in master yet in master it doesn't fail, here it does...

[MUCDK]

This file should not exist any more. It should be in tests/analysis_mixins/

[MUCDK]

please make sure that the file structure in the test folder corresponds to the file structure in the moscot module

[michalk8]

Shouldn't empty var_names throw? I'd expect if you don't want to use any, None should be passed.