Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple top level designs #177

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Conversation

benbr8
Copy link
Contributor

@benbr8 benbr8 commented Feb 4, 2022

This creates the possibility to simulate multiple toplevel designs in parallel with simulators which support this. It is implemented for Questa and Icarus.

One use case for this is simulating designs containing Xilinx IP, as outlined in #158.

Let me know what you think, and sorry for generating so much noise recently ;).

@benbr8 benbr8 changed the title added multitop feature Support for multiple top level designs Feb 4, 2022
@benbr8
Copy link
Contributor Author

benbr8 commented Feb 15, 2022

Hi, is this going to be considered, or should I implement a local solution? I'll be switching jobs, and I need to have a solution ready by end of the month.

@themperek themperek self-requested a review February 17, 2022 07:10
@themperek
Copy link
Owner

Hi, is this going to be considered, or should I implement a local solution? I'll be switching jobs, and I need to have a solution ready by end of the month.

I can do but not sure if I like it as it is now.

I would rather see toplevel_module to return just the first element.
One could add toplevel_module_list or something like this to get the list.
Same for toplevel_library.

Have a feeling this will look better.

@benbr8
Copy link
Contributor Author

benbr8 commented Feb 17, 2022

Hi, thanks for the feedback. I'm indifferent about the 'how' of the solution. I added your suggested changes :)

cocotb_test/simulator.py Outdated Show resolved Hide resolved
@themperek themperek merged commit 0f61c34 into themperek:master Feb 18, 2022
@themperek
Copy link
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants