Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The source code with the node_modules folder is accidentially compiled #35

Closed
stephanrauh opened this issue Nov 23, 2017 · 2 comments
Closed

Comments

@stephanrauh
Copy link

The TypeScript source code of the library is compiled. IMHO, you can prevent this by packaging the NPM module a bit differently. The compiled JavaScript is part of the NPM package, so TypeScript and Angular should ignore the source code altogether.

My Angular CLI project doesn't have a system-config.json, so I didn't add the configuration as suggested. Maybe that's why the problem comes up in my project (but that's just a guess).

I'm not entirely sure, but I think this blog describes how to get rid of the TypeScript files (and how to put them in a dedicated folder ignored by the compiler).

@themyth92
Copy link
Owner

Ok tks. I will take a look into this 👍

themyth92 added a commit that referenced this issue Jan 17, 2018
Seems like it is the cause of angular5 can not run

See #30, #35, #36, #38
themyth92 added a commit that referenced this issue Jan 17, 2018
Seems like it is the cause of angular5 can not run

See #30, #35, #36, #38
@themyth92
Copy link
Owner

Should be ok for angular5 now !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants