Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisibilityConverter for LocalAdapter does not use directory_visbility #148

Closed
MHC03 opened this issue Aug 8, 2023 · 2 comments · Fixed by #153
Closed

VisibilityConverter for LocalAdapter does not use directory_visbility #148

MHC03 opened this issue Aug 8, 2023 · 2 comments · Fixed by #153
Labels
Bug Work in progress

Comments

@MHC03
Copy link

MHC03 commented Aug 8, 2023

We had a local storage with visibility and directory_visibility as public. When the folder was created, it strangely had other permission than we configured in permissions.dir.public. Seems like the directory visibility is ignored on creation of the PortableVisibilityConverter here. This leads to the creation of nonexistent folders with the default visibility as private, thus a permission we did not set.

I am not sure, if that is as intended, but my suggestion would be to create the PortableVisibilityConverter with the given directory_visbility, by using it as $defaultForDirectories.
@maxhelias
Copy link
Collaborator

maxhelias commented Aug 12, 2023 •
edited
Loading

Indeed, with the local adapter the root folder is created by default with a private permission.
Work in progress here : #139

@maxhelias maxhelias mentioned this issue Oct 14, 2023
Merged
@maxhelias
Copy link
Collaborator

Can you check my PR #153 pls and tell me if it's ok ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Default visibility for directories maxhelias/flysystem-bundle
2 participants
@maxhelias @MHC03