Add the possibility to configure default visibility for directories #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Aug 12, 2023
| @@ -83,6 +84,7 @@ protected function configureDefinition(Definition $definition, array $options) | |||
| 'private' => (int) $options['permissions']['dir']['private'], | |||
| ], | |||
| ]) | |||
| ->addArgument($options['default_for_directories'] ?? Visibility::PRIVATE) | |||
There was a problem hiding this comment.
This will not fix the problem, default_for_directories cannot be set
|
Thank you for all your work. I made another PR that covers the other adapters. #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to configure the default visibility for directories.
This could cause some unexpected behavior, e.g. when the root directory of the local storage doesn't exist, it get's created, but using the default visibility and not the configured
directory_visibilityof the storage.With this PR it's at least possible to set the default visibility for the storage.
This could be considered as a follow up to #69