Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding storage name on flysystem.storage tag #31

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Adding storage name on flysystem.storage tag #31

merged 1 commit into from
Dec 20, 2019

Conversation

johndodev
Copy link
Contributor

@tgalopin
Copy link
Member

tgalopin commented Dec 17, 2019

Thanks very much for your PR :) !

It would be great to have a test for this (in Symfony 4.3+). I'm thinking about a kernel test (https://github.com/thephpleague/flysystem-bundle/tree/master/tests/Kernel) but where a service locator is created and extracted in the test to ensure it does contain the proper services.

Do you think you could have time to add this test :) ?

@johndodev
Copy link
Contributor Author

I don't know how to do that, I used to unit tests. if you already have in mind what you need you will be more efficient than me.

@tgalopin
Copy link
Member

I'll have a look :)

@tgalopin tgalopin merged commit fd9e1fb into thephpleague:master Dec 20, 2019
@tgalopin
Copy link
Member

Thanks @johndodev ! I'll add tests and use this feature in the new Lazy adapter i'm working on to implement DSN configuration, your issue was very helpful!

@johndodev
Copy link
Contributor Author

Pleasure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants