Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary DefinitionFactory circular reference in Adapter definitions builders #4

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Remove unecessary DefinitionFactory circular reference in Adapter definitions builders #4

merged 1 commit into from
Apr 19, 2019

Conversation

tgalopin
Copy link
Member

Fix #3

@tgalopin
Copy link
Member Author

@stof if you want to review it, don't hesitate ;)

@tgalopin tgalopin merged commit f1a4404 into master Apr 19, 2019
@tgalopin tgalopin deleted the remove-circular-reference branch April 19, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbstractAdapterDefinitionBuilder does not need the DefinitionFactory
2 participants
@tgalopin @stof