Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added streamReads config option to aws provider #57

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

JohnstonCode
Copy link
Contributor

@JohnstonCode JohnstonCode commented Nov 6, 2020

Since 1.0.28 Aws S3 Adapter V3, by default all readStream calls will result in a streamed HTTP response.

public function __construct(S3ClientInterface $client, $bucket, $prefix = '', array $options = [], $streamReads = true)

This PR add the config option to change this.

flysystem:
    storages:
        users.storage:
            adapter: 'aws'
            # visibility: public # Make the uploaded file publicly accessible in S3
            options:
                client: 'aws_client_service' # The service ID of the Aws\S3\S3Client instance
                bucket: 'bucket_name'
                prefix: 'optional/path/prefix'
                streamReads: true

Let me know if you would like me to add a check to see if this parameter is needed (people using older versions of Aws S3 Adapter V3).

@JohnstonCode
Copy link
Contributor Author

@tgalopin can you have a look at this whenever you have time please?

@tgalopin tgalopin merged commit 187394d into thephpleague:master Jan 20, 2022
@tgalopin
Copy link
Member

Thanks @JohnstonCode !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants