Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symfony 6 support #84

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Add Symfony 6 support #84

merged 3 commits into from
Dec 14, 2021

Conversation

AbdelilahJabri
Copy link
Contributor

No description provided.

@AbdelilahJabri
Copy link
Contributor Author

@tgalopin can you check this please?

tgalopin
tgalopin reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@tgalopin tgalopin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you add "minimum-stability": "dev" in the composer.json to run tests? It should be fine anyway, relying on dev branches is usually a good idea as long as we have versions constraints.

.github/workflows/test.yaml Outdated
@@ -66,3 +66,35 @@ jobs:
composer require --no-update --dev symfony/framework-bundle=$SYMFONY_VERSION symfony/yaml=$SYMFONY_VERSION
composer update --prefer-dist --no-interaction --no-ansi --no-progress
php vendor/bin/simple-phpunit

tests-php-7-4-symfony-6-0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this case, Symfony 6 requires PHP 8 :)

@gndk
Copy link

gndk commented Dec 2, 2021

@AbdelilahJabri Thanks for getting the PR started! Do you have time to continue with this or should somebody else take over? Seems like only minor changes are required to get this merged after we see a green pipeline for tests-php-8-0-symfony-6-0.

@tgalopin tgalopin mentioned this pull request Dec 6, 2021
Closed
@yoshz
Copy link

yoshz commented Dec 14, 2021

Any progress on this?
Removing the php-7.4 job and restarting the tests should probably already fix the tests.

@tgalopin
Copy link
Member

Thanks @AbdelilahJabri.

@tgalopin tgalopin merged commit 983a908 into thephpleague:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgalopin tgalopin tgalopin left review comments

@hamzanatek hamzanatek hamzanatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AbdelilahJabri @gndk @yoshz @tgalopin @hamzanatek