Encourage the use of "league/flysystem-sftp-v3" instead of "league/fl… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to thephpleague/flysystem#1261 |
This was referenced May 13, 2022
|
friendly ping @tgalopin 😃 |
|
The PHP 7.2 / Symfony 4.4 tests are failing, I guess because the version installed if probably old. Maybe it's time to release a new major dropping support for EOL tools. WDYT? |
|
Oh I didn't pay attention to the CI in 7.2. It's related to the version of flysystem which had a bad configuration of the .gitatttributes in 2.0.0 and still includes phpseclib v2 |
|
Not necessarily need to drop support now but I'm always for that kind of thing, I can work on it on another PR |
|
Thanks for the fix :) ! Merging |
|
If you wish to open a PR for Symfony 6+ and PHP 8+, that would be great :) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ysystem-sftp"