fix(docs): File permission should be octal in yaml #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the octal type this results in very weird file permissions
Tofandel
changed the title
Tofandel
changed the title
|
I'm not sure about this. For example the LocalFilesystemAdapter use the php function |
|
It's not a use case, it's a bug in the doc, chmod expects an octal value, if we don't use octal then we get the wrong permissions as explained in the doc you just linked ;) The problem is yaml interprets 0755 as a decimal and not an octal, to be an octal in yaml it needs to be prepended with |
|
Oh I just understood my mistake. Before Symfony 5.1, it was supported in the component and is not anymore. Sorry |
maxhelias
approved these changes
Aug 12, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the octal type this results in very weird file permissions