Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add azure blob storage #1407

Merged
merged 22 commits into from
Feb 12, 2022
Merged

Conversation

frankdejonge
Copy link
Member

No description provided.

@keatliang2005
Copy link

imo this should be dedicated adaptor package , and should not be directly merge at flysytem itself

example do it something like this instead
https://github.com/thephpleague/flysystem-aws-s3-v3/tree/3.x

@frankdejonge
Copy link
Member Author

Hi @keatliang2005, those other adapters are also maintained from this repo, they are published as a sub-split to their own repo for distribution.

@keatliang2005
Copy link

ah after peaking into 3.x branch now i see clearer. i was upgrading to Laravel 9, and it's using flysystem v3 and azure blob storage adaptor is missing for v2|v3

now i just wait this to be merged into the v3 branch

thanks for the awesome work there.

@jbraband
Copy link

Is there anything I can do to help with any remaining tasks on this PR?
With all checks having passed, is merging it just a matter of time?

@frankdejonge frankdejonge merged commit bc54bd8 into 3.x Feb 12, 2022
@frankdejonge frankdejonge deleted the feature/3.x/add-azure-blob-storage branch February 12, 2022 12:11
@jbraband
Copy link

thanks for the merge @frankdejonge !

@frankdejonge
Copy link
Member Author

👍 I'll release it later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants