Avoid type errors when public key is not retrieved #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with unstable connections, phpseclib may return `false` when retrieving the public key. That causes `null` to be passed down to `base64_decode()` and triggers a TypeError due to strict types. This exits early, preventing triggering the problem. However, testing is a bit tricky since we need an unstable connection.
lcobucci
commented
Apr 14, 2022
| $publicKey = $connection->getServerPublicHostKey(); | ||
|
|
||
| if ($publicKey === false) { | ||
| throw UnableToEstablishAuthenticityOfHost::becauseTheAuthenticityCantBeEstablished($this->host); |
There was a problem hiding this comment.
I feel bad about not providing any tests here (which would have caught the issue).
Having this method private and always instantiating SFTP make it slightly difficult to inject a stubbed connection to make sure we cover this behaviour.
Would love having ideas that don't involve using something like https://github.com/shopify/toxiproxy to mess up with the connection we use for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with unstable connections, phpseclib may return
falsewhen retrieving the public key. That causesnullto be passed down tobase64_decode()and triggers a TypeError due to strict types.This exits early, preventing triggering the problem.
However, testing is a bit tricky since we need an unstable connection (or stub things).