Verify SFTP retries when dealing with peer resets #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frankdejonge I'm not sure how these changes affect the |
|
@lcobucci yeah, those FTP containers are very unstable. I've implemented automatic retry mechanisms, but even then sometimes it's not good enough... I'll rerun the failed ones. |
This introduces a proxy that simulates different network issues and a client to manage it. That is handy to be able to test for issues that can only be reproduced in specific scenarios/environments. The management API provided here is slimmed down to only reproduce peer resets but can be further extended if/when necessary. More information: https://github.com/shopify/toxiproxy
This verifies that Flysystem SFTP adapter goes through all the configured tries before throwing an `UnableToConnectToSftpHost` exception. Reverting the fix applied in thephpleague#1451 makes the test to fail due to an unexpected `RuntimeException`. Applying this for phpseclib v2 is a bit tricky, though, due to the lack of knowledge on what has happened in the flow (e.g. `false` is returned when a connection cannot be established or when an authentication error happened). To make it work, the adapter for that version would need to verify if there's a connection or not all the time - which doesn't sound very good to me.
lcobucci
force-pushed
the
add-test-for-sftp-retries
branch
from
e068948 to
464a8b1
Compare
lcobucci
commented
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies that Flysystem SFTP adapter goes through all the configured tries before throwing an
UnableToConnectToSftpHostexception.Reverting the fix applied in #1451 makes the test to fail due to an unexpected
RuntimeException.Applying this for phpseclib v2 is a bit tricky, though, due to the lack of knowledge on what has happened in the flow (e.g.
falseis returned when a connection cannot be established or when an authentication error happened). To make it work, the adapter for that version would need to verify if there's a connection or not all the time - which doesn't sound very good to me.