hasExpired() should use self::getTimeNow()

thephpleague · Dec 11, 2024 · 3c8c2b4 · 3c8c2b4
1 parent 2d06e3e
commit 3c8c2b4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Token/AccessToken.php b/src/Token/AccessToken.php
@@ -204,7 +204,7 @@ public function hasExpired()
             throw new RuntimeException('"expires" is not set on the token');
         }
 
-        return $expires < time();
+        return $expires < $this->getTimeNow();
     }
 
     /**

diff --git a/test/src/Token/AccessTokenTest.php b/test/src/Token/AccessTokenTest.php
@@ -178,6 +178,22 @@ public function testHasExpiredWhenPropertySetInPast()
         self::tearDownForBackwardsCompatibility();
     }
 
+    public function testHasExpiredWhenTimeNowIsInFuture()
+    {
+        $options = [
+            'access_token' => 'mock_access_token',
+            'expires' => time(),
+        ];
+
+        $token = $this->getAccessToken($options);
+
+        $token->setTimeNow(time() + 60);
+
+        $this->assertTrue($token->hasExpired());
+
+        self::tearDownForBackwardsCompatibility();
+    }
+
     public function testCannotReportExpiredWhenNoExpirationSet()
     {
         $options = [
-Original file line number
+Diff line change
@@ Expand Up / @@ -204,7 +204,7 @@ public function hasExpired() @@
                 throw new RuntimeException('"expires" is not set on the token');
             }
-            return $expires < time();
+            return $expires < $this->getTimeNow();
         }
         /**
@@ Expand Down @@