Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding third-party Digi-Key provider to docs #1001

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

bggardner
Copy link
Contributor

No description provided.

@ramsey
Copy link
Contributor

ramsey commented Dec 10, 2024

In order to add your provider to our list of third-party providers, we require that the provider code include tests. Please include tests, and we'll accept this PR. Thanks!

@bggardner
Copy link
Contributor Author

Test added.

@ramsey
Copy link
Contributor

ramsey commented Dec 10, 2024

That was quick! Thanks!

Thank you for contributing! 🎉

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2455200) to head (f2b0e51).
Report is 22 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #1001   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       191       193    +2     
===========================================
  Files             20        20           
  Lines            516       521    +5     
===========================================
+ Hits             516       521    +5     

@ramsey ramsey merged commit 17f5b55 into thephpleague:master Dec 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants