Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to GitHub Actions #105

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Conversation

sunkan
Copy link
Contributor

@sunkan sunkan commented Dec 11, 2020

Here is first working draft of migration to github actions

I hade to disable nightly builds because of phpspec/prophecy not supporting nightly.

I also added a build step to verify that it works with --prefer-lowest composer option

You can see the output from the last build here
https://github.com/sunkan/openapi-psr7-validator/actions/runs/415797193

@scaytrase
Copy link
Member

I hade to disable nightly builds because of phpspec/prophecy not supporting nightly.

That's the purpose of allow-failures for nighly. To keep track of things that are not working.Is it possible to have it, but non-blocking?

@sunkan
Copy link
Contributor Author

sunkan commented Dec 11, 2020

@scaytrase

I've updated the action with nightly that is none blocking.

you can see the output here https://github.com/sunkan/openapi-psr7-validator/actions/runs/415935071

I also reworked the highest/lowest version testing

@scaytrase
Copy link
Member

looks nice

@sunkan
Copy link
Contributor Author

sunkan commented Dec 11, 2020

I think this is finished to merge if you approve

@scaytrase scaytrase merged commit adc58e9 into thephpleague:master Dec 11, 2020
@scaytrase
Copy link
Member

Thanks @sunkan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants