Add static analysis with PHPStan #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
reviewed
Dec 13, 2020
scaytrase
requested changes
Dec 13, 2020
canvural
force-pushed
the
static-analysis
branch
2 times, most recently
from
4bec9ab to
efa09ee
Compare
canvural
force-pushed
the
static-analysis
branch
from
efa09ee to
93b9fd5
Compare
scaytrase
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds static analysis with PHPStan.
Code is already very well written, so there were no big issues. And this PR will also help with making sure it stays this way.