Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(typeMismatch): Add test on querystring parameters with array values of number #141

Merged
merged 3 commits into from
Sep 24, 2021
Merged

test(typeMismatch): Add test on querystring parameters with array values of number #141

merged 3 commits into from
Sep 24, 2021

Conversation

Identity-labs
Copy link
Contributor

@scaytrase
Copy link
Member

Please run vendor/bin/phpcbf. I see one failing test but it seems irrelevant to new code, looks like some changes in latest dependencies

@scaytrase scaytrase linked an issue Sep 24, 2021 that may be closed by this pull request
Parameters of type number in query or path #140
Closed
@Identity-labs
Copy link
Contributor Author

Code style is fixed.
Yes one test is failing, but on master too.

@scaytrase
Copy link
Member

I wil deal it by myself later, don't worry

scaytrase
scaytrase approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scaytrase scaytrase merged commit e4ed24c into thephpleague:master Sep 24, 2021
@scaytrase
Copy link
Member

Thanks @Identity-labs !

@Identity-labs
Copy link
Contributor Author

Thanks :) A tag will be created ?

@scaytrase
Copy link
Member

Sure, I'm checking failing test now and will release a tag after I fix it or decide it's non-blocking

@scaytrase
Copy link
Member

@Identity-labs here it is https://github.com/thephpleague/openapi-psr7-validator/releases/tag/0.16.2 I've considered this a bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaytrase scaytrase scaytrase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameters of type number in query or path
2 participants
@Identity-labs @scaytrase