Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema\TypeFormats\StringDate: fix check + add tests #144

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Schema\TypeFormats\StringDate: fix check + add tests #144

merged 2 commits into from
Oct 6, 2021

Conversation

dmachehin
Copy link
Contributor

Fix check date string, originally wrong detect for values: 2021-0-32, 2021-09-32

scaytrase
scaytrase requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Small fix requested and we good to go

@scaytrase
Copy link
Member

Thanks @dmachehin !

@scaytrase scaytrase merged commit a87c402 into thephpleague:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaytrase scaytrase scaytrase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmachehin @scaytrase