Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Status Code Ranges 2XX, 3XX, 4XX, 5XX #159

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Support Status Code Ranges 2XX, 3XX, 4XX, 5XX #159

merged 5 commits into from
Mar 1, 2022

Conversation

wolffc
Copy link
Contributor

@wolffc wolffc commented Feb 28, 2022

fixes #158

@scaytrase
Copy link
Member

Loogs good, but can you please provide a test case for new feature?

@scaytrase
Copy link
Member

Tests are failing

@wolffc
Copy link
Contributor Author

wolffc commented Feb 28, 2022

i will take care of fixin the issues and providing a test case

@wolffc
Add ResponseStatusCodesWithWildcards Test for Specfinder
fd9bede 
Test Different Response Adresses and check if the correct
Response Schema is Found

thephpleague#158
@wolffc
Copy link
Contributor Author

wolffc commented Mar 1, 2022

@scaytrase added test and seems to be passing scutinzer let me know if anything else is still missing.

scaytrase
scaytrase approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scaytrase scaytrase merged commit 5f98f98 into thephpleague:master Mar 1, 2022
@scaytrase
Copy link
Member

Thanks @wolffc !

@scaytrase
Copy link
Member

https://github.com/thephpleague/openapi-psr7-validator/releases/tag/0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaytrase scaytrase scaytrase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Pattern Response Status Codes (2XX, 3XX, 4XX, and 5XX)
2 participants
@wolffc @scaytrase