Fix #147: multipart/form-data validation #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea is set value to array by keys, that is supported in parse_str.
Problem exists in direct parsing of multipart/form-data
scaytrase
reviewed
Jan 27, 2023
| ['list' => [['another_key' => 0], ['another_key' => 1]]], | ||
| ]; | ||
|
|
||
| yield 'somehow sets value on incorrect key #1' => [ |
There was a problem hiding this comment.
These are looks like bugs for me. I expect some kind of exception should be thrown here
scaytrase
reviewed
Jan 27, 2023
| Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryOmz20xyMCkE27rN7 | ||
|
|
||
| ------WebKitFormBoundaryOmz20xyMCkE27rN7 | ||
| Content-Disposition: form-data; name="arrayOfNumbers[]" |
There was a problem hiding this comment.
https://swagger.io/docs/specification/serialization/
shouldn't this work only if deep object serialization specified? this is the only way I see arrayOfNumbers[] can work alongside with openapi
scaytrase
requested changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #147