Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure additionalProperty uses correct schema. #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure additionalProperty uses correct schema. #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1335f4
Ensure additionalProperty uses correct schema.
fiasco Jan 29, 2023
ebd94ea
Fixed unit tests and added case for additionalProperties of type object.
fiasco Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Schema/Keywords/Properties.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public function validate($data, array $properties, $additionalProperties): void
// if not covered by "properties"
$schemaValidator->validate(
$data[$propName],
$additionalProperties,
$additionalProperties->properties[$propName] ?? $additionalProperties,
$this->dataBreadCrumb->addCrumb($propName)
);
}
Expand Down
19 changes: 19 additions & 0 deletions tests/Schema/Keywords/PropertiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,23 @@ public function testItInfersObjectTypeGreen(): void
$this->expectException(KeywordMismatch::class);
(new SchemaValidator())->validate($data, $schema);
}

public function testItValidatesAdditionalPropertiesBlue(): void
{
$spec = <<<SPEC
schema:
type: object
additionalProperties:
type: object
properties:
flag:
type: boolean
SPEC;

$schema = $this->loadRawSchema($spec);
$data = ['flag' => true];

(new SchemaValidator())->validate($data, $schema);
$this->addToAssertionCount(1);
}
}