Handle path parameters for arrays correctly #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters for serialized arrays was using the same deserialization check. There are different formats for header, query and path. Split up the validation of arrays into two different sets to allow different validation for path and header/query parameters. The changes will validate path parameters for arrays but not objects which is still not working.
I think one can contribute them later if needed indeed. |
|
Thanks @tjcambio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters for serialized arrays was using the same deserialization check.
There are different formats for header, query and path. Split up the validation of arrays into two different sets to allow different validation for path and header/query parameters.
The changes will validate path parameters for arrays but not objects which is still not working.
Because of objects within path parameter is probably the most unused things in the specs these have been left out intentionally.