Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies: psr/http-message 2.x & league/uri 7.x #205

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

deegital
Copy link
Contributor

  • Support for psr/http-message 2.x
    v2.x added return types to the interfaces, should be fine - tests running

  • Support for league/uri 7.x
    This package is only used within \League\OpenAPIValidation\Schema\TypeFormats\StringURI to check if an url is parsable:

try {
    UriString::parse($value);

    return true;
} catch (SyntaxError $error) {
    return false;
}

- Support for league/uri 7.x
@MaSpeng
Copy link

MaSpeng commented Aug 14, 2023

An update for respect/stringifier might also be good, and could also be done in a separate PR.

@deegital
Copy link
Contributor Author

deegital commented Aug 15, 2023

@MaSpeng I've just taken a look at it, but noticed it's not a explicit dependency of this package, but an implicit one via respect/validation.

The latest version of that package is already supported by the current required version:
"respect/validation": "^1.1.3 || ^2.0",

Requests for bumping the stringy version then need to be added here: https://github.com/Respect/Validation
Hope that helps :)

Edit: There is already an MR to support stringify up to version 2.0 with some discussion: Respect/Validation#1424

@schodemeiss
Copy link

Any chance of progressing this PR at all?

I have a dependency on league/uri ^7.0, but this package is preventing that upgrade unfortunately :-(.

@deegital deegital changed the title Updated dependencies Updated dependencies: psr/http-message 2.x & league/uri 7.x Aug 28, 2023
@deegital
Copy link
Contributor Author

@schodemeiss feel free to use my branch in the meantime by adding the repository to your composer file

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/deegital/openapi-psr7-validator"
    }
],

and this version of the package to require/require-dev:

"league/openapi-psr7-validator": "dev-dependency-updates",

I will keep it at least until the PR is merged or it is added to the lib by other commits

@deegital
Copy link
Contributor Author

@scaytrase sorry for tagging, but I've noticed you did the last approval of an MR for this repo. What's missing to move on with this MR?

KentarouTakeda added a commit to KentarouTakeda/thephpleague-openapi-psr7-validator that referenced this pull request Jan 2, 2024
@scaytrase scaytrase merged commit e91da8f into thephpleague:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants