Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CI coverage and tighten execution #215

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KentarouTakeda
Copy link
Contributor

@KentarouTakeda KentarouTakeda commented Jan 2, 2024

Overview

  • Added 8.2 and 8.3 to the php version to be tested in CI.
  • Fixed test failure on php-8.1 and later by using phpunit according to php version and officially added to CI.

Detail

A detailed step-by-step explanation of all the fixes made in this pull request.

  1. 3472e1e : Added 8.1, 8.2, 8.3 to the php version to be tested.
    • All tests now fail on php 8.1 and later, which were previously marked as experimental. Here are the results.
    • This is because phpunit:^7 installed with --prefer-lowest does not support php-8.1 or later.
  2. a048521 : Use different versions of phpunit depending on the php version to be tested.
    • With this fix, all tests that previously failed now pass.
    • So far, most of the issues have been resolved, but the CI results are showing many warning messages below. Here are the results.

      The following actions uses node12 which is deprecated and will be forced to run on node16: shivammathur/[email protected], actions/checkout@v2.

  3. fdd7d09 : Use the latest version of setup-php.
    • All CI warning messages have disappeared. Here are the results.
  4. UPDATE: 2024-01-04 11:15 JST c372bc3 Adjusted the way to specify dependencies to pass the Scrutinizer CI (installed version remains the same)

Motivation

According to Packagist usage statistics, more than 90% of the versions of php currently installed with this library are 8.1 or later. Testing on real versions will improve reliability.

PHP-Versions-statistics

These tests may also be required when changing the version of dependent libraries. This is because the updated version is likely to use a newer PHP version.

For example, the following pull request also suggests a broader version dependency:

@KentarouTakeda KentarouTakeda marked this pull request as draft January 4, 2024 02:06
@KentarouTakeda KentarouTakeda marked this pull request as ready for review January 4, 2024 02:19
@KentarouTakeda
Copy link
Contributor Author

Adjusted the way dependencies are specified to pass the Scrutinizer CI. Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant