Keep inner exceptions if oneOf or anyOf fails #46
Conversation
src/Schema/Keywords/OneOf.php
Outdated
| foreach ($oneOf as $schema) { | ||
| try { | ||
| $schemaValidator->validate($data, $schema, $this->dataBreadCrumb); | ||
| $matchedCount++; | ||
| } catch (SchemaMismatch $e) { | ||
| // that did not match... its ok | ||
| $innerExceptions[] = $e; | ||
| } | ||
| } | ||
|
|
||
| if ($matchedCount !== 1) { |
There was a problem hiding this comment.
For new exception we should distinguish between zero and >1 matches. For zero matches - use aggregated exception. for >1 we should just provide some useful info, since there is nothing bad with unmatched ones
There was a problem hiding this comment.
thanks for fast reply. what do you think about this:
- keeping logic like it is for zero matches
- add another exception type "TooManyValidSchemas"* that works like InvalidSchemaCombination but instead of $innerExceptions it stores an array of $validSchemas -> this will be thrown if matched schemas is > 1
*if you have an idea for some better name please tell me.
There was a problem hiding this comment.
InvalidSchemaCombination naming should be changed to NotEnoughValidSchemas then or something similar, since current naming covers both cases. All the other parts of the idea sound good.
There was a problem hiding this comment.
i see, that makes sense. i've updated the code. feel free to check it again :)
…s and TooManyValidSchemas exception classes
|
Thanks @ckdot ! |
this will solve #13