Callback validation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaytrase
requested changes
Sep 21, 2019
digilist
force-pushed
the
52-callback-validation
branch
from
5e7da22 to
5c5359e
Compare
scaytrase
requested changes
Oct 29, 2019
There was a problem hiding this comment.
Sorry for long review, I'm pretty new to callbacks in schema, so I have to take several iterations to dig it.
In general it looks good to me, but few more improvements required. I see some incoming drawbacks In SpecFinder usages, but this is not your problem and could be refactored later some day
digilist
force-pushed
the
52-callback-validation
branch
from
5c5359e to
0fb47c6
Compare
scaytrase
reviewed
Nov 6, 2019
digilist
force-pushed
the
52-callback-validation
branch
from
0fb47c6 to
4b08e9d
Compare
|
Thank you for your review and merging it! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening my PR to implement callback validation from the previous repository here again.
fixes #3