feat: return False when we do not discover any environment variables #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsks
changed the title
larsks
force-pushed
the
fix/load-dotenv-return-code
branch
from
48e3fc7
to
020ac34
Compare
The docstring for load_dotenv was missing a word, rendering it confusing. This commits modifies it for clarity.
This modifies Dotenv.set_as_environment_variables to return False if we have not discovered any environment variables via either `dotenv_path` or `stream`. The return value gets passed through to `load_dotenv`, so this can be used to determine if `dotenv.load_dotenv` was able to set anything. Closes theskumar#321
larsks
force-pushed
the
fix/load-dotenv-return-code
branch
from
020ac34
to
1371bb8
Compare
This was referenced Jun 5, 2022
theskumar
approved these changes
Jun 5, 2022
theskumar
reviewed
Jun 5, 2022
theskumar
changed the title
theskumar
added a commit
that referenced
this pull request
Jun 5, 2022
* master: feat: return False when we do not discover any environment variables (#388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies Dotenv.set_as_environment_variables to return False
if we have not discovered any environment variables via either
dotenv_pathorstream.The return value gets passed through to
load_dotenv, so this can beused to determine if
dotenv.load_dotenvwas able to set anything.Closes #321