Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some filepaths on Fedora where libykcs11 may be found #1286

Merged

Conversation

trishankatdatadog
Copy link
Contributor

I added some filepaths to the shared libykcs11 library may be found on Fedora after installing yubico-piv-tool.

Signed-off-by: Trishank K Kuppusamy [email protected]

@docker-jenkins
Copy link

Can one of the admins verify this patch?

@endophage
Copy link
Contributor

Hey, the linting failed:

trustmanager/yubikey/pkcs11_linux.go
Makefile:99: recipe for target 'lint' failed

Signed-off-by: Trishank K Kuppusamy <[email protected]>
@trishankatdatadog
Copy link
Contributor Author

should be fixed now, i hope

@endophage
Copy link
Contributor

Jenkins test this please

Copy link
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Not sure what the codecov discrepancy is, but it seems unrelated.

Thanks for the update!

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "trishank_kuppusamy/fedora-pkcs11" [email protected]:trishankatdatadog/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354175080
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@cyli
Copy link
Contributor

cyli commented Feb 6, 2018

Ah sorry, the "merge master" button in github breaks the DCO. :| Unfortunately you have to rebase. Not sure if this will help the coverage issues, but fingers crossed!

@trishankatdatadog
Copy link
Contributor Author

No problem, sorry about that, let me get around to this ASAP

@trishankatdatadog trishankatdatadog force-pushed the trishank_kuppusamy/fedora-pkcs11 branch from 4b1c6af to ab433b8 Compare February 6, 2018 01:18
@trishankatdatadog
Copy link
Contributor Author

I dropped the merge. Hope this helps. Thanks!

@cyli cyli merged commit c4d1207 into notaryproject:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants