Respecting HTTP status code #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2013 20:32
Checking HTTP error codes and cancel download if HTTP status Code >= 400
|
Nice, thank you. Now I think I will add some unit tests on this lib soon, because those things need to be tested :) Congrats on your first PR 👏 |
thibaultcha
added a commit
that referenced
this pull request
Oct 16, 2013
Watching HTTP error status codes
Closed
thibaultcha
added a commit
that referenced
this pull request
Oct 25, 2013
Watching HTTP error status codes
|
Hi, After some struggling with Git, I had to rebase commits to fix the authors of some commits, including yours. I fixed it but I need your Github email address so GitHub can display your profile in the "contributors" section of this project. Would you consider send me your email at [email protected] or here? (I will delete it afterwards). Sorry. Thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.