[CI/CD] Improve Docker development #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
snicki13
approved these changes
Sep 2, 2021
|
You mentioned, that the build is now cached. Is buildx providing some sort of cache? I understood, that the multi-staged build process within Dockerfile provides a cache. Is it lost when built with Github Actions without buildx? |
No, but The problem is that each execution of the Github action (here the build process) is done in a separate container. Docker itself caches the created stages during the build, but since the container that executed this build process is "destroyed" again and the next time a new one is spanned, it no longer has the cache of the previous container and rebuilds everything. To solve this "problem" Github offers the possibility to save the caching data (Github Actions Cache service API). This is enabled with these two options of the digital-classroom/.github/workflows/docker-image.yml Lines 54 to 55 in 6530566 |
snicki13
added a commit
that referenced
this pull request
Sep 3, 2021
* .gitignore and additional parameter * experiment with angular * Native HTTPS * https keystore * Update parameters * Added self-signed certificates + docker-compose for image usage. * Update documentation * Update documentation * image-based docker-compose for deployment * Refactoring * move docker-compose * Refactoring * Initial RSocket connection! * Client Rsocket with composite metadata! * Remove legacy event system * Begin RSocket Security! * Successfully authenticated user via JWT & RSocket * Removed LinkedHashSet as order-keeping collection for tickets. Sorting of tickets will be done in the client. Introduced interface "ClassroomDependent" for objects logically depending on an instance of DigitalClassroom. * Overhauled exceptions * Prepare event system * Rebuild downstream API. Clearer separation of responsibilites. Improved reactivity through Mono / Flux + clearer code. * RSocket experiments. * Eventsystem over RSocket in place. some refactoring in frontend. * JWT refactoring * removed unnecessary dependencies. * cleanup * Fixed api "/create" idempotency. * Updated notes. * published functions. * Minor changes * Removed internalMeetingId. Simplified model classes. * Backend Classroom API -> RSocket. Ticket init implemented. SetOnceProperty for "lateinit val" workaround. Tickets have ticketId from classroom exclusive sequence. * RSocketService general purpose interface. * Minor changes + classroom information. * cleanup web-gui * Ticket Service in place and refactoring of web-gui * UserEvent system + ticket fixes. * Display username in header. * beautify * Detect disconnects! * minor * typed UserRole in Client. * Dynamic websocket endpoint * simplified ngIfs and removed leave button, since JS cannot close windows it did not spawn. * Fixed Ticket assignment and double display of current user in user list. * use map to ensure uniqueness in user list. Map, because we only want to consider userId when checking for equality. * finalize instead of map to reduce publishing * Prepare for conference handling. Refactoring. * Implemented conference system. * Conference joining works. * [CI/CD][Docker] added Caching & push image to ghcr.io (#18) * Invitations - not functional! * Fixed invitation sending in caller. * Fixed invitations. * .gitignore and additional parameter * experiment with angular * Update parameters * Added self-signed certificates + docker-compose for image usage. * image-based docker-compose for deployment * move docker-compose * Refactoring * Initial RSocket connection! * Client Rsocket with composite metadata! * Remove legacy event system * Begin RSocket Security! * Successfully authenticated user via JWT & RSocket * Removed LinkedHashSet as order-keeping collection for tickets. Sorting of tickets will be done in the client. Introduced interface "ClassroomDependent" for objects logically depending on an instance of DigitalClassroom. * Overhauled exceptions * Prepare event system * Rebuild downstream API. Clearer separation of responsibilites. Improved reactivity through Mono / Flux + clearer code. * RSocket experiments. * Eventsystem over RSocket in place. some refactoring in frontend. * JWT refactoring * removed unnecessary dependencies. * cleanup * Fixed api "/create" idempotency. * Updated notes. * published functions. * Minor changes * Removed internalMeetingId. Simplified model classes. * Backend Classroom API -> RSocket. Ticket init implemented. SetOnceProperty for "lateinit val" workaround. Tickets have ticketId from classroom exclusive sequence. * RSocketService general purpose interface. * Minor changes + classroom information. * cleanup web-gui * Ticket Service in place and refactoring of web-gui * UserEvent system + ticket fixes. * Display username in header. * beautify * Detect disconnects! * minor * typed UserRole in Client. * Dynamic websocket endpoint * simplified ngIfs and removed leave button, since JS cannot close windows it did not spawn. * Fixed Ticket assignment and double display of current user in user list. * use map to ensure uniqueness in user list. Map, because we only want to consider userId when checking for equality. * finalize instead of map to reduce publishing * Prepare for conference handling. Refactoring. * Implemented conference system. * Conference joining works. * Invitations - not functional! * Fixed invitation sending in caller. * Fixed invitations. Co-authored-by: Max Stephan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the deployment of the Docker Container as follows:
master. If a Relase (git tag) is created it will be created with the tagslatestand the name of the Relase (e.g. v1.0.0). @snicki13 what do you think about this?resolves #17