log: log unexpected error and ignore healthcheck (#196)

thoas · Oct 14, 2024 · 7019f5b · 7019f5b
1 parent c644fff
commit 7019f5b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/failure/http.go b/failure/http.go
@@ -30,6 +30,7 @@ func Handle(h Handler) gin.HandlerFunc {
 				c.String(http.StatusBadRequest, cerr.Error())
 			}
 
+			c.Error(err)
 			panic(err)
 		}
 	}

diff --git a/server/http.go b/server/http.go
@@ -70,13 +70,16 @@ func (s *HTTPServer) Init() error {
 		}
 	)
 
+	router.GET("/healthcheck", handlers.healthcheck(time.Now().UTC()))
+
+	router.Use(middleware.NewLogger(s.processor.Logger))
+
 	if s.config.Debug {
 		router.Use(gin.Recovery())
 	} else {
 		router.Use(middleware.Recover)
 	}
 
-	router.Use(middleware.NewLogger(s.processor.Logger))
 	router.Use(middleware.Metrics)
 
 	if s.config.Sentry != nil {
@@ -112,8 +115,6 @@ func (s *HTTPServer) Init() error {
 		}))
 	}
 
-	router.GET("/healthcheck", handlers.healthcheck(time.Now().UTC()))
-
 	restrictIPAddresses := middleware.RestrictIPAddresses(s.config.Options.AllowedIPAddresses)
 
 	if s.config.Options.EnableStats {
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,7 @@ func Handle(h Handler) gin.HandlerFunc { @@
     				c.String(http.StatusBadRequest, cerr.Error())
     			}
+    			c.Error(err)
     			panic(err)
     		}
     	}
@@ Expand Down @@