-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage no longer compatible with pytest 7 #83
Comments
The warning was turned into an error by our pytest config, and thus resulted in test failures. There's an existing issue for pytest-flake8¹ that's 3 months old now with no movement so far. setuptools is also dealing with the same warnings.² If other issues arise that aren't fixed upstream, a longer term solution could be doing what we do with mypy and simply invoke flake8 directly instead of via a pytest plugin. ¹ tholo/pytest-flake8#83 ² pypa/setuptools#3079
See jaraco/pytest-checkdocs#9 and jaraco/pytest-perf#5 for approaches I used to fix this issue. |
pytest-flake8 seems abandoned at this point Related issues in other repositories: * tholo/pytest-flake8#83 * miketheman/pytest-socket#82
The following warning/error also shows up with 7.0.1:
|
With
After upgrading to
But after upgrading to Should this PR be closed, or are there some other remaining incompatibilities with Pytest 7.x which I'm just not hitting in my project? |
pytest-flake8 has been broken for over a year with flake8 >= 5.0 [1][2][3], and has not had any commits since March 2022. Drop in favor of simply invoking flake8 separately outside of pytest. Ensure that "make check" now invokes flake8. [1] tholo/pytest-flake8#83 [2] tholo/pytest-flake8#87 [3] tholo/pytest-flake8#92 Signed-off-by: Daniel Harding <[email protected]>
pytest-flake8 has been broken for over a year with pytest >= 7.0 [1] and more than six months with flake8 >= 5.0 [2][3], and has not had any commits since March 2022. Drop in favor of simply invoking flake8 separately outside of pytest. Ensure that "make check" now invokes flake8. [1] tholo/pytest-flake8#83 [2] tholo/pytest-flake8#87 [3] tholo/pytest-flake8#92 Signed-off-by: Daniel Harding <[email protected]>
See pytest-dev/pytest#8435 for background and jaraco/pytest-checkdocs#9 for an example of how I addressed the issue in pytest-checkdocs.
The text was updated successfully, but these errors were encountered: